Upgrade Pinia to v4 - #1228
Merged
Merged
Conversation
dgee2
force-pushed
the
deps-pinia-major
branch
from
August 13, 2026 21:45
a7c96b7 to
711400a
Compare
dgee2
marked this pull request as ready for review
August 14, 2026 20:43
Contributor
There was a problem hiding this comment.
Pull request overview
This PR upgrades the Vue app’s state-management dependency Pinia from v3.0.4 → v4.0.2 in ui/menu-website, updating both the manifest and lockfile to keep dependency resolution consistent.
Changes:
- Bumped
piniadependency inui/menu-website/package.jsonto^4.0.2. - Updated
ui/menu-website/pnpm-lock.yamlto reflect the resolved Pinia v4 dependency graph (including@vue/devtools-apiresolution).
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ui/menu-website/package.json | Updates the Pinia version requirement to ^4.0.2. |
| ui/menu-website/pnpm-lock.yaml | Refreshes the lockfile to the new Pinia v4 resolved versions and transitive dependencies. |
Files not reviewed (1)
- ui/menu-website/pnpm-lock.yaml: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
dgee2
force-pushed
the
deps-pinia-major
branch
from
August 14, 2026 20:57
711400a to
fe1ab45
Compare
Bumps pinia 3.0.4 -> 4.0.2. Usage in this repo is minimal (createPinia() in main.ts only, no defineStore/storeToRefs call sites), and pinia's own changelog describes v4 as "only technically breaking": the package is ESM-only (already the case here) and @vue/devtools-api moved from bundled to a real dependency of pinia itself, so no changes were needed on our side. Verified: lint, build, unit tests, storybook interaction tests (78/78). Co-authored-by: Claude <noreply@anthropic.com>
dgee2
force-pushed
the
deps-pinia-major
branch
from
August 14, 2026 21:12
fe1ab45 to
2848adb
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps pinia 3.0.4 -> 4.0.2. Usage in this repo is minimal
(createPinia() in main.ts only, no defineStore/storeToRefs call
sites), and pinia's own changelog describes v4 as "only technically
breaking": the package is ESM-only (already the case here) and
@vue/devtools-api moved from bundled to a real dependency of pinia
itself, so no changes were needed on our side.
Verified: lint, build, unit tests, storybook interaction tests
(78/78).
Co-authored-by: Claude noreply@anthropic.com
Stack created with GitHub Stacks CLI • Give Feedback 💬